feat: adds support for ratelimit metrics monitoring in grafana #4083
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
==========================================
- Coverage 66.01% 65.98% -0.03%
==========================================
Files 197 197
Lines 23971 23971
==========================================
- Hits 15825 15818 -7
- Misses 7021 7026 +5
- Partials 1125 1127 +2 ☔ View full report in Codecov by Sentry. |
| "disableTextWrap": false, | ||
| "editorMode": "builder", | ||
| "exemplar": false, | ||
| "expr": "ratelimit_service_rate_limit_total_hits{domain=\"default/eg/http\", key1=\"httproute/default/http-ratelimit/rule/0/match/0/ratelimit_example_httproute/default/http-ratelimit/rule/0/match/0/ratelimit_example\", key2=\"rule-0-match-0_rule-0-match-0\"}", |
There was a problem hiding this comment.
should this be a variable and read from a drop down ?
There was a problem hiding this comment.
Created a variable DefaultDomain for domain value default/eg/http and kept key1 & key2 as it is because I think key1 & key2 values change according to HTTPRoute configuration and other configs.
There was a problem hiding this comment.
@arkodg Should I create variables for key1 & key2 as well ?
| "disableTextWrap": false, | ||
| "editorMode": "code", | ||
| "exemplar": false, | ||
| "expr": "ratelimit_service_rate_limit_near_limit{domain=\"default/eg/http\",key1=\"httproute/default/http-ratelimit/rule/0/match/0/ratelimit_example_httproute/default/http-ratelimit/rule/0/match/0/ratelimit_example\",key2=\"rule-0-match-0_rule-0-match-0\"}", |
MdSahil-oss
force-pushed
the
grafana-dashboard
branch
2 times, most recently
from
3dd81d3 to
b2ad4a3
Compare
MdSahil-oss
force-pushed
the
grafana-dashboard
branch
2 times, most recently
from
efa81ab to
fff1a75
Compare
There was a problem hiding this comment.
I don't think this is the right place for the global ratelimit dashboard, can you move this into a new dashboard, probably with name global-ratelimit.json ?
Signed-off-by: MdSahil-oss <[email protected]>
MdSahil-oss
force-pushed
the
grafana-dashboard
branch
from
936345c to
dc545d6
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
What type of PR is this?
feat: adds support for ratelimit metrics monitoring in grafana
What this PR does / why we need it:
Adds new visualization panels in grafana dashboard
Envoy Gateway GlobalWhich issue(s) this PR fixes:
Fixes #3871
This PR depends on #4073