chore: enable copyloopvar lint #4047
Conversation
Signed-off-by: shawnh2 <[email protected]>
| @@ -435,7 +433,7 @@ func (r *gatewayAPIReconciler) processBackendRefs(ctx context.Context, gwcResour | |||
| backendRefKind, string(backendRef.Name)) | |||
| } else { | |||
| for _, endpointSlice := range endpointSliceList.Items { | |||
| endpointSlice := endpointSlice | |||
| endpointSlice := endpointSlice //nolint:copyloopvar | |||
There was a problem hiding this comment.
this kind of loopvar is needed since its address has been referenced
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
+ Coverage 67.75% 67.78% +0.02%
==========================================
Files 187 187
Lines 22891 22865 -26
==========================================
- Hits 15509 15498 -11
+ Misses 6272 6257 -15
Partials 1110 1110 ☔ View full report in Codecov by Sentry. |
| @@ -34,7 +34,7 @@ func (r *gatewayAPIReconciler) processTLSRoutes(ctx context.Context, gatewayName | |||
| } | |||
|
|
|||
| for _, tlsRoute := range tlsRouteList.Items { | |||
| tlsRoute := tlsRoute | |||
| tlsRoute := tlsRoute //nolint:copyloopvar | |||
There was a problem hiding this comment.
curious why its needed here ?
There was a problem hiding this comment.
same as #4047 (comment), in L95 it's referenced and got appended into resourceTree.TLSRoutes.
There was a problem hiding this comment.
remove this will pass copyloopvar, but not exportloopref, becasue: exporting a pointer for the loop variable tlsRoute
|
/retest |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3244, replace & close #3959