Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backend tls docs #4039

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: backend tls docs #4039

merged 2 commits into from
Aug 13, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Aug 12, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4019

Signed-off-by: Guy Daich <[email protected]>
@guydc guydc requested a review from a team as a code owner August 12, 2024 22:21
arkodg
arkodg previously approved these changes Aug 12, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkodg arkodg requested review from a team August 12, 2024 22:23
Signed-off-by: Guy Daich <[email protected]>
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.64%. Comparing base (eeb62c8) to head (5e88429).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4039      +/-   ##
==========================================
+ Coverage   67.59%   67.64%   +0.04%     
==========================================
  Files         186      186              
  Lines       22757    22757              
==========================================
+ Hits        15383    15394      +11     
+ Misses       6268     6259       -9     
+ Partials     1106     1104       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkodg arkodg merged commit 22dde3f into envoyproxy:main Aug 13, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend TLS: Gateway to Backend tutorial is broken
3 participants