Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-nodeSelector #4017

Merged
merged 7 commits into from
Aug 28, 2024
Merged

add-nodeSelector #4017

merged 7 commits into from
Aug 28, 2024

Conversation

magorKathy
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
It's needed so we can configure a NodeSelector for Envoy gateway pods within values file.
A common use case for nodeSelector configuration is to control the placement of pods on specific nodes within a cluster based on node labels. This allows to ensure that certain workloads run only on nodes that meet specific criteria, such as hardware specifications, geographic location, or other custom attributes.

Which issue(s) this PR fixes:
N/A

@magorKathy magorKathy requested a review from a team as a code owner August 8, 2024 12:19
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (6e70981) to head (4eeaa58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4017      +/-   ##
==========================================
+ Coverage   67.88%   67.94%   +0.06%     
==========================================
  Files         187      187              
  Lines       23023    23023              
==========================================
+ Hits        15630    15644      +14     
+ Misses       6273     6262      -11     
+ Partials     1120     1117       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Aug 8, 2024

thanks for raising this PR @magorKathy, added a comment

@zirain
Copy link
Member

zirain commented Aug 12, 2024

please fix DCO, and run make -k gen-check

Signed-off-by: Kathy Magor <[email protected]>
@zirain
Copy link
Member

zirain commented Aug 28, 2024

donot merge main, this one is simple.
Otherwise I need approve CI for first-time contributor again and again, thanks!

@zirain zirain requested a review from arkodg August 28, 2024 03:01
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg merged commit 2395f7f into envoyproxy:main Aug 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants