-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-nodeSelector #4017
add-nodeSelector #4017
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4017 +/- ##
==========================================
+ Coverage 67.88% 67.94% +0.06%
==========================================
Files 187 187
Lines 23023 23023
==========================================
+ Hits 15630 15644 +14
+ Misses 6273 6262 -11
+ Partials 1120 1117 -3 ☔ View full report in Codecov by Sentry. |
thanks for raising this PR @magorKathy, added a comment |
please fix DCO, and run |
Signed-off-by: Kathy Magor <[email protected]>
cb18f53
to
ef5174f
Compare
Signed-off-by: Kathy Magor <[email protected]>
donot merge main, this one is simple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !
What type of PR is this?
What this PR does / why we need it:
It's needed so we can configure a NodeSelector for Envoy gateway pods within values file.
A common use case for nodeSelector configuration is to control the placement of pods on specific nodes within a cluster based on node labels. This allows to ensure that certain workloads run only on nodes that meet specific criteria, such as hardware specifications, geographic location, or other custom attributes.
Which issue(s) this PR fixes:
N/A