Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cluster settings for tracing and accesslog backends #4012

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

liorokman
Copy link
Contributor

Fixes #3069

@liorokman liorokman requested a review from a team as a code owner August 7, 2024 09:52
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 95.94595% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (975b1e8) to head (2a6ad3a).

Files Patch % Lines
internal/gatewayapi/listener.go 87.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4012      +/-   ##
==========================================
+ Coverage   67.61%   67.66%   +0.05%     
==========================================
  Files         185      185              
  Lines       22578    22621      +43     
==========================================
+ Hits        15265    15306      +41     
- Misses       6217     6218       +1     
- Partials     1096     1097       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liorokman
Copy link
Contributor Author

/retest

@zirain
Copy link
Member

zirain commented Aug 7, 2024

xref: #3954

@liorokman
Copy link
Contributor Author

/retest

2 similar comments
@zirain
Copy link
Member

zirain commented Aug 8, 2024

/retest

@liorokman
Copy link
Contributor Author

/retest

@liorokman
Copy link
Contributor Author

The E2E tests are failing because the WASM module can't be found:

        message: 'Wasm: wasm module download failed after 1 attempts, last error:
          wasm module download request failed: status code 404.'

This reproduces when trying manually as well:

wget https://raw.githubusercontent.com/envoyproxy/envoy/main/examples/wasm-cc/lib/envoy_filter_http_wasm_example.wasm
--2024-08-08 12:50:37--  https://raw.githubusercontent.com/envoyproxy/envoy/main/examples/wasm-cc/lib/envoy_filter_http_wasm_example.wasm
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.108.133, 185.199.109.133, 185.199.111.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.108.133|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-08-08 12:50:37 ERROR 404: Not Found.

@guydc @zirain any ideas how to get this to work?

@guydc
Copy link
Contributor

guydc commented Aug 8, 2024

CC @zhaohuabing

@liorokman
Copy link
Contributor Author

liorokman commented Aug 8, 2024

Checking the Envoy repository, it seems that the examples were moved to their own repository recently: envoyproxy/envoy@56be4f4

The links probably need to be updated in this repository. See #4014

@zirain
Copy link
Member

zirain commented Aug 8, 2024

@liorokman can you open an issue to track and disable those tests?

@liorokman
Copy link
Contributor Author

@liorokman can you open an issue to track and disable those tests?

Once #4014 is merged, I'll rebase and these tests will start working correctly.

@liorokman liorokman force-pushed the cluster-settings-tracing-accesslog branch from cca0149 to 2a6ad3a Compare August 8, 2024 12:32
@liorokman
Copy link
Contributor Author

/retest

Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@guydc
Copy link
Contributor

guydc commented Aug 9, 2024

Thanks!

@guydc guydc merged commit 176811d into envoyproxy:main Aug 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cluster settings for non-xRoute BackendRefs
3 participants