-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cluster settings for tracing and accesslog backends #4012
feat: support cluster settings for tracing and accesslog backends #4012
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4012 +/- ##
==========================================
+ Coverage 67.61% 67.66% +0.05%
==========================================
Files 185 185
Lines 22578 22621 +43
==========================================
+ Hits 15265 15306 +41
- Misses 6217 6218 +1
- Partials 1096 1097 +1 ☔ View full report in Codecov by Sentry. |
/retest |
xref: #3954 |
/retest |
2 similar comments
/retest |
/retest |
The E2E tests are failing because the WASM module can't be found:
This reproduces when trying manually as well:
|
CC @zhaohuabing |
Checking the Envoy repository, it seems that the examples were moved to their own repository recently: envoyproxy/envoy@56be4f4 The links probably need to be updated in this repository. See #4014 |
@liorokman can you open an issue to track and disable those tests? |
Once #4014 is merged, I'll rebase and these tests will start working correctly. |
Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Lior Okman <[email protected]>
cca0149
to
2a6ad3a
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks! |
Fixes #3069