Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Steps for migrating to Envoy Gateway #3973

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

Manoramsharma
Copy link
Contributor

What type of PR is this?
docs: Add a doc that can help users who want to migrate to Envoy Gateway

What this PR does / why we need it:
This PR highlights the ingress2gateway tool that can facilitate the migration to envoy gateway

Which issue(s) this PR fixes:

Fixes #3742

@Manoramsharma Manoramsharma requested a review from a team as a code owner July 30, 2024 06:57
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (eeb62c8) to head (de5550b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3973      +/-   ##
==========================================
- Coverage   67.59%   67.58%   -0.01%     
==========================================
  Files         186      186              
  Lines       22757    22757              
==========================================
- Hits        15383    15381       -2     
- Misses       6268     6270       +2     
  Partials     1106     1106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manoramsharma
Copy link
Contributor Author

@arkodg PTAL once !!!

Signed-off-by: Manoramsharma <[email protected]>
@Manoramsharma Manoramsharma requested a review from arkodg July 31, 2024 07:49
arkodg
arkodg previously approved these changes Jul 31, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !
this is a good start, we can further enhance this doc in the future

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that we need to configure the gatewayclass?

@Manoramsharma
Copy link
Contributor Author

Should we mention that we need to configure the gatewayclass?

Yes , we can . Could you please mention in which step, I will add this.

zirain
zirain previously approved these changes Aug 10, 2024
@arkodg
Copy link
Contributor

arkodg commented Aug 10, 2024

hey @Manoramsharma will the generated output be good enough or does the user need to also create a GatewayClass to link to the Envoy Gateway controller to ensure that the generated `HTTPRoutes`` get programmed in the data plane ?

@Manoramsharma
Copy link
Contributor Author

hey @Manoramsharma will the generated output be good enough or does the user need to also create a GatewayClass to link to the Envoy Gateway controller to ensure that the generated `HTTPRoutes`` get programmed in the data plane ?

Hi @arkodg you are right, GatewayClass defines the controller responsible for managing Gateways and programming the data plane. Without this linkage, the Gateway controller won't know which resources it should handle, and the generated HTTPRoutes won't be programmed correctly.

Let me just update the PR mentioning the steps to configure the Gateway class.

@Manoramsharma Manoramsharma dismissed stale reviews from zirain and arkodg via 67d8759 August 10, 2024 08:49
@zirain zirain merged commit 229bf91 into envoyproxy:main Aug 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Steps for migrating to Envoy Gateway
4 participants