-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Steps for migrating to Envoy Gateway #3973
Conversation
Signed-off-by: Manoramsharma <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3973 +/- ##
==========================================
- Coverage 67.59% 67.58% -0.01%
==========================================
Files 186 186
Lines 22757 22757
==========================================
- Hits 15383 15381 -2
- Misses 6268 6270 +2
Partials 1106 1106 ☔ View full report in Codecov by Sentry. |
@arkodg PTAL once !!! |
Signed-off-by: Manoramsharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !
this is a good start, we can further enhance this doc in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that we need to configure the gatewayclass?
Yes , we can . Could you please mention in which step, I will add this. |
hey @Manoramsharma will the generated output be good enough or does the user need to also create a GatewayClass to link to the Envoy Gateway controller to ensure that the generated `HTTPRoutes`` get programmed in the data plane ? |
Hi @arkodg you are right, GatewayClass defines the controller responsible for managing Gateways and programming the data plane. Without this linkage, the Gateway controller won't know which resources it should handle, and the generated HTTPRoutes won't be programmed correctly. Let me just update the PR mentioning the steps to configure the Gateway class. |
Signed-off-by: Manoramsharma <[email protected]>
Signed-off-by: Manoramsharma <[email protected]>
What type of PR is this?
docs: Add a doc that can help users who want to migrate to Envoy Gateway
What this PR does / why we need it:
This PR highlights the
ingress2gateway
tool that can facilitate the migration to envoy gatewayWhich issue(s) this PR fixes:
Fixes #3742