Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add resoure requirements for statsd exporter #3957

Merged

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Jul 26, 2024

All EG components have resource requirements in their container specs except the statsd exporter. This PR adds the missing resource requirements for the statsd exporter container.

@zhaohuabing zhaohuabing requested a review from a team as a code owner July 26, 2024 06:50
@zirain
Copy link
Member

zirain commented Jul 26, 2024

should make it configurable?

@zhaohuabing
Copy link
Member Author

should make it configurable?

Since we want to replace it with a built-in exporter, I'd vote to wait till someone requests it.

@Xunzhuo Xunzhuo merged commit b4b2985 into envoyproxy:main Jul 26, 2024
22 checks passed
@zhaohuabing zhaohuabing deleted the statsd-expoerter-default-resoure branch September 29, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants