printing name of the target when a policy fails to attach #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Sadovnikov <[email protected]>
zirain
reviewed
Jul 24, 2024
internal/gatewayapi/testdata/securitypolicy-status-conditions.out.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
- Coverage 67.40% 67.38% -0.02%
==========================================
Files 183 183
Lines 22435 22440 +5
==========================================
- Hits 15123 15122 -1
- Misses 6225 6227 +2
- Partials 1087 1091 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Viktor Sadovnikov <[email protected]>
|
@zirain, I corrected the files with the expected test outcomes. Could you please approve the workflows? |
Signed-off-by: Viktor Sadovnikov <[email protected]>
|
The trailing spaces in the test files are removed |
zirain
approved these changes
Jul 24, 2024
zhaohuabing
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Policies in the
v1.1.xversions will have multiple targets. This PR makes error messages on failures to attach to a target more specific.Which issue(s) this PR fixes:
No issues were logged for this
@zirain, this PR replaces #3917, which I messed up with the wrong commits. It also includes changes in the test files.