docs: fix grammar error --> Typo in envoy-patch-policy.md "garunteed"

[gwarren3210]

FIxed the typo of "garunteed" into "guaranteed"

What type of PR is this?
docs: fix grammar error

[arkodg]

hey thanks for fixing this @gwarren3210 !

1. @zirain @zhaohuabing with the new doc infra changes in place, will someone need to update 3 files having the same content ?
2. also why did codespell not catch this

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.33%. Comparing base (ca2d80b) to head (cfd03d6).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3892      +/-   ##
==========================================
+ Coverage   66.29%   66.33%   +0.03%     
==========================================
  Files         209      209              
  Lines       32035    32035              
==========================================
+ Hits        21239    21249      +10     
+ Misses       9536     9527       -9     
+ Partials     1260     1259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zirain]

hey thanks for fixing this @gwarren3210 !

1. @zirain @zhaohuabing with the new doc infra changes in place, will someone need to update 3 files having the same content ?
2. also why did codespell not catch this

1. you should always change content under latest or v[x].[y], make gen-chek will do the copy.
2. let me check why.

[zhaohuabing]

Yes, docs directory is auto-generated.

[zirain]

codespell site/content/en/latest/tasks/extensibility/envoy-patch-policy.md

not output from codespell

[zhaohuabing]

@gwarren3210 Please run make gen-check and submit the generated files to fix the gen-check.

[gwarren3210]

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/[email protected]/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

[zirain]

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/[email protected]/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

linux: sudo apt-get install libbtrfs-dev -y
macos: brew install libffi

[gwarren3210]

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/[email protected]/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

linux: sudo apt-get install libbtrfs-dev -y macos: brew install libffi

I run into the same issue of it not changing any of the files. It passes all the tests locally, is it possible that a test is broken?

[zirain]

I am able to run it on my local machine without any changes happening to files but when running it in github.dev I get the following error. Also running it on my local machine did not generate any files.

go test -timeout 30s github.com/envoyproxy/gateway/internal/cmd/egctl --override-testdata=true
# github.com/containers/storage/drivers/btrfs
/go/pkg/mod/github.com/containers/[email protected]/drivers/btrfs/btrfs.go:12:10: fatal error: btrfs/ioctl.h: No such file or directory
   12 | #include <btrfs/ioctl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
FAIL    github.com/envoyproxy/gateway/internal/cmd/egctl [build failed]
FAIL
make[1]: *** [tools/make/golang.mk:51: go.testdata.complete] Error 1
make[1]: Leaving directory '/workspaces/gateway'
make: *** [Makefile:18: _run] Error 2

linux: sudo apt-get install libbtrfs-dev -y macos: brew install libffi

I run into the same issue of it not changing any of the files. It passes all the tests locally, is it possible that a test is broken?

no, it just because you lack of some lib that is needed by this project.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[zirain]

@gwarren3210 still plan to move this forward?

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[shawnh2]

close this one, #4958 fix it