Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update v1.1.0-rc.1.yaml #3810

Closed
wants to merge 2 commits into from
Closed

docs: update v1.1.0-rc.1.yaml #3810

wants to merge 2 commits into from

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Jul 10, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
#3336 was a breaking change

Signed-off-by: Guy Daich <[email protected]>
@guydc guydc requested a review from a team as a code owner July 10, 2024 18:46
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.03%. Comparing base (cbfb261) to head (6e1172a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3810   +/-   ##
=======================================
  Coverage   69.02%   69.03%           
=======================================
  Files         176      176           
  Lines       21760    21760           
=======================================
+ Hits        15019    15021    +2     
+ Misses       5661     5660    -1     
+ Partials     1080     1079    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could add a few words to explain why this has been changed.

@zirain
Copy link
Member

zirain commented Jul 11, 2024

did you run make release-notes-docs locally?

@zirain
Copy link
Member

zirain commented Jul 11, 2024

should wait #3815

@Xunzhuo
Copy link
Member

Xunzhuo commented Jul 11, 2024

Plz run make generate locally, then submit a new commit @guydc :)

@Xunzhuo Xunzhuo changed the title Update v1.1.0-rc.1.yaml docs: update v1.1.0-rc.1.yaml Jul 11, 2024
@guydc guydc closed this Jul 11, 2024
@guydc guydc deleted the guydc-patch-1 branch July 16, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants