Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: make accesslog format optional #3770

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Jul 7, 2024

for #3768, this should be optional to simply the example.

@zirain zirain requested a review from a team as a code owner July 7, 2024 03:12
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.01%. Comparing base (9e13e1a) to head (2e26413).

Files Patch % Lines
api/v1alpha1/validation/envoyproxy_validate.go 60.00% 4 Missing ⚠️
internal/gatewayapi/listener.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3770   +/-   ##
=======================================
  Coverage   69.00%   69.01%           
=======================================
  Files         176      176           
  Lines       21751    21758    +7     
=======================================
+ Hits        15010    15017    +7     
  Misses       5661     5661           
  Partials     1080     1080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit 6791d6d into envoyproxy:main Jul 8, 2024
27 checks passed
@zirain zirain deleted the accesslog-format-optional branch July 8, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants