Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: should use TCP as default protocol #3749

Merged
merged 4 commits into from
Jul 4, 2024
Merged

xds: should use TCP as default protocol #3749

merged 4 commits into from
Jul 4, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Jul 4, 2024

found this when debuging #3748

@zirain zirain requested a review from a team as a code owner July 4, 2024 05:16
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (780704c) to head (9005c87).

Files Patch % Lines
internal/gatewayapi/route.go 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3749      +/-   ##
==========================================
- Coverage   68.99%   68.98%   -0.01%     
==========================================
  Files         176      176              
  Lines       21741    21744       +3     
==========================================
+ Hits        15000    15001       +1     
- Misses       5660     5662       +2     
  Partials     1081     1081

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
support grpc
7603592 
Signed-off-by: zirain <[email protected]>
@zirain zirain force-pushed the backend-protocol branch from 7b28ab7 to 7603592 Compare July 4, 2024 06:43
@zirain
fix e2e
0df42bd 
Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Member Author

zirain commented Jul 4, 2024

/retest

@zirain zirain mentioned this pull request Jul 4, 2024
Merged
shawnh2
shawnh2 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

Xunzhuo
Xunzhuo approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Xunzhuo Xunzhuo merged commit d6b5415 into envoyproxy:main Jul 4, 2024
14 checks passed
@zirain zirain deleted the backend-protocol branch July 4, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zirain @zhaohuabing @shawnh2 @Xunzhuo