Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add CEL to accesslog test #3730

Merged
merged 4 commits into from
Jul 3, 2024
Merged

e2e: add CEL to accesslog test #3730

merged 4 commits into from
Jul 3, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Jul 2, 2024

fix: #3735

@zirain zirain requested a review from a team as a code owner July 2, 2024 11:58
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.03%. Comparing base (de8a53d) to head (4da1e3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3730      +/-   ##
==========================================
+ Coverage   69.01%   69.03%   +0.01%     
==========================================
  Files         176      176              
  Lines       21688    21688              
==========================================
+ Hits        14969    14973       +4     
+ Misses       5638     5634       -4     
  Partials     1081     1081              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Member Author

zirain commented Jul 2, 2024

Positive test worked as expected.

guydc
guydc previously approved these changes Jul 2, 2024
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zirain zirain added the hold do not merge label Jul 2, 2024
@zirain
Copy link
Member Author

zirain commented Jul 2, 2024

will add negetive tests in this one.

@arkodg arkodg added this to the v1.1.0-rc1 milestone Jul 3, 2024
@arkodg arkodg modified the milestones: v1.1.0-rc1, v1.1.0 Jul 3, 2024
@zirain zirain force-pushed the cel-e2e branch 2 times, most recently from 14dbfcd to f161426 Compare July 3, 2024 02:53
@zirain zirain changed the title e2e: add CEL to accesslog e2e: add CEL to accesslog test Jul 3, 2024
@zirain zirain removed the hold do not merge label Jul 3, 2024
@zirain zirain requested a review from guydc July 3, 2024 08:02
zirain added 4 commits July 3, 2024 16:03
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zirain zirain merged commit 5050e36 into envoyproxy:main Jul 3, 2024
24 checks passed
@zirain zirain deleted the cel-e2e branch July 3, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: CEL Expression for Access Logging
5 participants