Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Modify prerequisite go version #3711

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

sanposhiho
Copy link
Contributor

@sanposhiho sanposhiho commented Jun 30, 2024

What type of PR is this?

What this PR does / why we need it:

We're on golang v1.22.x, and this PR modifies the prerequisite based on it.
https://github.com/envoyproxy/gateway/blob/main/go.mod#L3

FYI, actually maybe we can just mention 1.21+ due to the following improvement, instead of mention the specific version, which is troublesome as we have to update the page every time we upgrade go version.

After installing Go 1.21, you’ll never have to manually download and install a Go toolchain again. The go command can do it for you.
https://go.dev/blog/toolchain

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Kensei Nakada <[email protected]>
@sanposhiho sanposhiho requested a review from a team as a code owner June 30, 2024 15:46
@arkodg arkodg requested review from a team July 1, 2024 16:53
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (51c6eb4) to head (6f3e33b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
- Coverage   68.81%   68.79%   -0.02%     
==========================================
  Files         175      175              
  Lines       21525    21525              
==========================================
- Hits        14812    14808       -4     
- Misses       5636     5638       +2     
- Partials     1077     1079       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain merged commit 9a2a7f6 into envoyproxy:main Jul 2, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants