docs: Fix typo in bootstrap config #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jelle Besseling <[email protected]>
zirain
approved these changes
Jun 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3710 +/- ##
==========================================
+ Coverage 68.81% 68.84% +0.03%
==========================================
Files 175 175
Lines 21525 21525
==========================================
+ Hits 14812 14819 +7
+ Misses 5636 5629 -7
Partials 1077 1077 ☔ View full report in Codecov by Sentry. |
|
/retest |
shawnh2
approved these changes
Jul 1, 2024
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jul 1, 2024
Fix typo in bootstrap config Signed-off-by: Jelle Besseling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Make the example config match the api spec
What this PR does / why we need it:
The example config is invalid, the key should be
valueand notbootstrapaccording to the API reference: https://gateway.envoyproxy.io/v0.6.0/api/extension_types/#proxybootstrap