Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move benchmark-test job in build_and_test.yaml #3692

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Jun 28, 2024

What type of PR is this?

What this PR does / why we need it:

Runs after build is succeeded, save some time in CI.

Which issue(s) this PR fixes:

Fixes #

@shawnh2 shawnh2 requested a review from a team as a code owner June 28, 2024 01:49
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (51c6eb4) to head (ed9149b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3692   +/-   ##
=======================================
  Coverage   68.81%   68.81%           
=======================================
  Files         175      175           
  Lines       21525    21525           
=======================================
  Hits        14812    14812           
  Misses       5636     5636           
  Partials     1077     1077           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2 shawnh2 mentioned this pull request Jun 28, 2024
10 tasks
Signed-off-by: shawnh2 <[email protected]>
@shawnh2
Copy link
Contributor Author

shawnh2 commented Jun 30, 2024

/retest

@shawnh2 shawnh2 requested review from a team June 30, 2024 08:02
@arkodg arkodg merged commit 828edfb into envoyproxy:main Jul 1, 2024
24 checks passed
@shawnh2 shawnh2 deleted the update-benchmark-ci branch July 1, 2024 19:27
guydc pushed a commit to guydc/gateway that referenced this pull request Jul 1, 2024
* add benchmark-test job in build_and_test.yaml

Signed-off-by: shawnh2 <[email protected]>

* fix lint

Signed-off-by: shawnh2 <[email protected]>

* reduce benchmark test duration to boost ci

Signed-off-by: shawnh2 <[email protected]>

---------

Signed-off-by: shawnh2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants