Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: introduce shortcode boilerplate #3652

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Jun 22, 2024

Introduce a new shortcode boilerplate to simply the usage.

the shortcode took from istio/istio.io

@zirain zirain requested a review from a team as a code owner June 22, 2024 14:09
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.27%. Comparing base (258eecd) to head (450a058).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3652      +/-   ##
==========================================
+ Coverage   68.25%   68.27%   +0.01%     
==========================================
  Files         170      170              
  Lines       20760    20760              
==========================================
+ Hits        14170    14174       +4     
+ Misses       5569     5566       -3     
+ Partials     1021     1020       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for introducing this

@zirain zirain enabled auto-merge (squash) June 24, 2024 02:48
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks !

@zirain zirain merged commit 798132c into envoyproxy:main Jun 24, 2024
26 checks passed
@zirain zirain deleted the shortcode/boilerplates branch June 24, 2024 21:35
bjlhlin pushed a commit to bjlhlin/gateway that referenced this pull request Jun 25, 2024
bjlhlin pushed a commit to bjlhlin/gateway that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants