chore: update gateway-addons-helm #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zirain
commented
Jun 22, 2024
•
zirain
commented
- disable grafana-agent and loki canary
- merge and clean makefile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3649 +/- ##
==========================================
+ Coverage 68.25% 68.27% +0.01%
==========================================
Files 170 170
Lines 20760 20760
==========================================
+ Hits 14170 14174 +4
+ Misses 5569 5566 -3
+ Partials 1021 1020 -1 ☔ View full report in Codecov by Sentry. |
|
wait #3610 |
zirain
force-pushed
the
use-gateway-addons-helm
branch
2 times, most recently
from
819d569 to
8e09ae4
Compare
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
use-gateway-addons-helm
branch
from
8e09ae4 to
6b2c348
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
use-gateway-addons-helm
branch
from
3863978 to
fad9aba
Compare
|
/retest |
arkodg
reviewed
Jun 24, 2024
arkodg
approved these changes
Jun 25, 2024
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 26, 2024
* update gateway-addons-helm Signed-off-by: zirain <[email protected]> * disabled selfMonitoring Signed-off-by: zirain <[email protected]> * update test Signed-off-by: zirain <[email protected]> * cleanup helm makefile Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> * template addon in monitoring namespace Signed-off-by: zirain <[email protected]> * add more test Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: bjlhlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.