fix: do not propagate well-known port number for xds portRedirect #3628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irect Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3628 +/- ##
==========================================
- Coverage 68.38% 68.36% -0.02%
==========================================
Files 170 170
Lines 20707 20707
==========================================
- Hits 14160 14157 -3
- Misses 5527 5529 +2
- Partials 1020 1021 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <[email protected]>
|
/retest |
zirain
approved these changes
Jun 22, 2024
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: “bjlhlin” <“[email protected]”>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: “bjlhlin” <“[email protected]”> Signed-off-by: bjlhlin <[email protected]>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: “bjlhlin” <“[email protected]”> Signed-off-by: bjlhlin <[email protected]>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: “bjlhlin” <“[email protected]”> Signed-off-by: bjlhlin <[email protected]>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: “bjlhlin” <“[email protected]”> Signed-off-by: bjlhlin <[email protected]>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: “bjlhlin” <“[email protected]”> Signed-off-by: bjlhlin <[email protected]>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 25, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: bjlhlin <[email protected]>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 26, 2024
…voyproxy#3628) * do not propagate well-known port number in xds translator for portRedirect Signed-off-by: shawnh2 <[email protected]> * fix yaml lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: bjlhlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3589