chore: enable importas for lint #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
==========================================
+ Coverage 68.17% 68.20% +0.03%
==========================================
Files 168 168
Lines 20484 20484
==========================================
+ Hits 13964 13971 +7
+ Misses 5511 5507 -4
+ Partials 1009 1006 -3 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Jun 13, 2024
| alias: apiextensionsv1 | ||
| - pkg: sigs.k8s.io/mcs-api/pkg/apis/v1alpha1 | ||
| alias: mcsapiv1a1 | ||
| - pkg: k8s.io/api/(\w+)/(v[\w\d]+) |
There was a problem hiding this comment.
match in regexp, like matching k8s.io/api/policy/v1, the alias will be policyv1. same for k8s.io/api/core/v1 etc
cnvergence
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #