feat(translator): Add formatter support for OpenTelemetry access logger #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dingkang Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3597 +/- ##
==========================================
- Coverage 68.30% 68.26% -0.04%
==========================================
Files 169 169
Lines 20618 20646 +28
==========================================
+ Hits 14083 14094 +11
- Misses 5519 5530 +11
- Partials 1016 1022 +6 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Jun 12, 2024
zirain
reviewed
Jun 12, 2024
zirain
reviewed
Jun 12, 2024
|
cc @arkodg - I think that this is another feature that will require Envoy 1.31 in EG 1.1. |
Signed-off-by: Dingkang Li <[email protected]>
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
zirain
approved these changes
Jun 16, 2024
|
it would be better to have an e2e test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add formatter support for OpenTelemetry access logger
Which issue(s) this PR fixes:
Fixes #3570