feat(translator): Implement http health check filter #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dingkang Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3596 +/- ##
==========================================
+ Coverage 68.22% 68.33% +0.10%
==========================================
Files 168 169 +1
Lines 20560 20618 +58
==========================================
+ Hits 14028 14090 +62
+ Misses 5520 5516 -4
Partials 1012 1012 ☔ View full report in Codecov by Sentry. |
|
thanks @aoledk this is great, can you also add an e2e for this that pings the healthCheck endpoint and gets a |
Signed-off-by: Dingkang Li <[email protected]>
shawnh2
reviewed
Jun 14, 2024
test/e2e/tests/health_check.go
Outdated
| ConformanceTests = append(ConformanceTests, HealthCheckTest) | ||
| } | ||
|
|
||
| var HealthCheckTest = suite.ConformanceTest{ |
There was a problem hiding this comment.
can we rename this into DownstreamHealthCheck? Since this health check is in CTP, as we also have health check in BTP, and the UpstreamHealthCheck e2e test case will be added soon.
There was a problem hiding this comment.
+1 prefer ListenerHealthCheck
Signed-off-by: Dingkang Li <[email protected]>
shawnh2
approved these changes
Jun 15, 2024
Signed-off-by: Dingkang Li <[email protected]>
arkodg
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow #3540
Which issue(s) this PR fixes:
Fixes #3258