docs: rm backend redirect docs #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkodg
force-pushed
the
fix-redirect-docs
branch
from
1e48cd1 to
6ea02ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3591 +/- ##
==========================================
- Coverage 68.35% 68.27% -0.08%
==========================================
Files 170 170
Lines 20760 20760
==========================================
- Hits 14190 14174 -16
- Misses 5552 5566 +14
- Partials 1018 1020 +2 ☔ View full report in Codecov by Sentry. |
cnvergence
approved these changes
Jun 12, 2024
* dont use `port: 443` in the redirect example * dont specify a backendRefs when the filter is a redirect filter Fixes: envoyproxy#3589 Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
force-pushed
the
fix-redirect-docs
branch
from
6ea02ec to
7e4437e
Compare
zhaohuabing
approved these changes
Jun 25, 2024
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 26, 2024
docs: update redirect tasks * dont use `port: 443` in the redirect example * dont specify a backendRefs when the filter is a redirect filter Fixes: envoyproxy#3589 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: bjlhlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port: 443in the redirect exampleRelates to: #3589