feat: Allow configuring tolerations for the EG control plane installed via Helm

[coro]

What this PR does / why we need it:

Allows the EG operator to be scheduled on nodes with taints. For example, in our cluster, we have a core set of control plane nodes with a NoSchedule taint. This PR allows the EG operator to be scheduled on those nodes.

Example Helm values.yaml:

deployment:
 pod:
  tolerations:
   - key: "custom.taint"
     operator: "Equal"
     value: "custom.value"

This PR also fixes some indentation in the topologySpreadConstraints field for the Deployment template - it was inconsistently indented with the rest of the generated manifest.

[coro]

Looks like there's a flake in one of the CI jobs:

error - 2024-06-11 13:57:51,299 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 329 seconds."}

Could a maintainer please rerun this test? Thanks!

[zirain]

Looks like there's a flake in one of the CI jobs:

error - 2024-06-11 13:57:51,299 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 329 seconds."}

Could a maintainer please rerun this test? Thanks!

you can reply with /retest to trigger.

BTW, can you add a test for this new feature?

[shawnh2]

add test for this under https://github.com/envoyproxy/gateway/tree/main/test/helm

[coro]

@zirain @shawnh2 Added tests, thanks for the pointer. Note I had to change the type of the topologySpreadConstraints as it was previously an object instead of a list.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.16%. Comparing base (242d69f) to head (83dee2d).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3587   +/-   ##
=======================================
  Coverage   68.16%   68.16%           
=======================================
  Files         168      168           
  Lines       20408    20408           
=======================================
  Hits        13912    13912           
  Misses       5494     5494           
  Partials     1002     1002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coro]

/retest

[coro]

/retest

[arkodg]

LGTM thanks !

[shawnh2]

LGTM! Thanks for adding this!