bug: ClientTrafficPolicy resources are prevented from targeting a SectionName by an incorrect CEL validation #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientTrafficPolicy resources. Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Lior Okman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
+ Coverage 68.14% 68.24% +0.09%
==========================================
Files 168 168
Lines 20408 20408
==========================================
+ Hits 13908 13927 +19
+ Misses 5497 5482 -15
+ Partials 1003 999 -4 ☔ View full report in Codecov by Sentry. |
|
/retest |
guydc
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed CEL validation that prevents specifying a
SectionNameforClientTrafficPolicyresources.The
ClientTrafficPolicytranslation does in-fact support targeting a specificSectionName, the CEL validation is wrong.