-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add certgen description into chart readme #3569
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
+ Coverage 68.19% 68.22% +0.03%
==========================================
Files 168 168
Lines 20408 20560 +152
==========================================
+ Hits 13918 14028 +110
- Misses 5490 5520 +30
- Partials 1000 1012 +12 ☔ View full report in Codecov by Sentry. |
PTAL |
ci |
Signed-off-by: ShyunnY <[email protected]>
@ShyunnY you will also need to run |
weird how it didn't fail |
Does the $ make helm-docs
make[1]: Entering directory '/home/shyunn/envoy-gateway'
make[1]: *** No rule to make target 'helm-docs'. Stop.
make[1]: Leaving directory '/home/shyunn/envoy-gateway'
make: *** [Makefile:18: _run] Error 2 |
Signed-off-by: ShyunnY <[email protected]>
it's but it seems we cannot generate content from the comments in helm chart. |
looks like |
Signed-off-by: ShyunnY <[email protected]>
I have done that. I checked the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
What type of PR is this?
doc: add certgen description into chart readme
What this PR does / why we need it:
Which issue(s) this PR fixes:
ref: #3521