Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automatically import Grafana dashboards when installing gateway-addons-helm #3556

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Jun 6, 2024

What type of PR is this?

What this PR does / why we need it:

When deploying gateway-addons-helm successfully, we will get dashboards automatically import:

image

Which issue(s) this PR fixes:

Fixes #

@shawnh2 shawnh2 requested a review from a team as a code owner June 6, 2024 09:29
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.16%. Comparing base (3bd8f35) to head (f97a555).

Current head f97a555 differs from pull request most recent head 460aade

Please upload reports for the commit 460aade to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3556   +/-   ##
=======================================
  Coverage   68.16%   68.16%           
=======================================
  Files         168      168           
  Lines       20408    20408           
=======================================
  Hits        13912    13912           
  Misses       5494     5494           
  Partials     1002     1002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team and zhaohuabing June 7, 2024 17:19
@arkodg arkodg requested review from a team June 7, 2024 18:15
@shawnh2 shawnh2 requested a review from zhaohuabing June 11, 2024 03:12
@zirain zirain merged commit 337c4c8 into envoyproxy:main Jun 11, 2024
21 checks passed
@shawnh2 shawnh2 deleted the grafana-dashboards-auto-import branch June 11, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants