Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: backend #3550

Merged
merged 8 commits into from
Jun 11, 2024
Merged

docs: backend #3550

merged 8 commits into from
Jun 11, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Jun 5, 2024

What this PR does / why we need it:
Docs for Backend API.

Which issue(s) this PR fixes:

Fixes #3549

Signed-off-by: Guy Daich <[email protected]>
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.14%. Comparing base (33fceb0) to head (c542a97).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3550   +/-   ##
=======================================
  Coverage   68.14%   68.14%           
=======================================
  Files         168      168           
  Lines       20408    20408           
=======================================
  Hits        13908    13908           
  Misses       5497     5497           
  Partials     1003     1003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Guy Daich <[email protected]>
@@ -0,0 +1,208 @@
---
title: "Backend Routing"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the contents here into routing-outside-kubernetes.md and push the endpointslice to the bottom of the page, saying "in case dont want to enable the enableBackend knob, here's another way ..". ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to build out this doc to cover additional use cases like unix sockets (once these are supported for more common use cases like ext-auth, RL, ..). I also feel like this is a more experimental feature at this time, without much production burn time, so I'm not sure that we should recommend it as the go-to approach. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg lets keep as is

guydc added 2 commits June 5, 2024 18:12
@guydc guydc marked this pull request as ready for review June 6, 2024 00:47
@guydc guydc requested a review from a team as a code owner June 6, 2024 00:47
@guydc
Copy link
Contributor Author

guydc commented Jun 6, 2024

/retest

## Motivation
The Backend API was added to support several use cases:
- Allowing users to integrate Envoy with services (Ext Auth, Rate Limit, ALS, ...) using Unix Domain Sockets, which are currently not supported by K8s.
- Simplify [routing to cluster-external backends][], which currently requires users to maintain both K8s `Service` and `Endpoint` resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Simplify [routing to cluster-external backends][], which currently requires users to maintain both K8s `Service` and `Endpoint` resources.
- Simplify [routing to cluster-external backends][], which currently requires users to maintain both K8s `Service` and `EndpointSlice` resources.


## Warning

Similar to the K8s Endpoint API, the Backend API can be misused to allow traffic to be sent to otherwise restricted destinations, as described in [CVE-2021-25740][].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Similar to the K8s Endpoint API, the Backend API can be misused to allow traffic to be sent to otherwise restricted destinations, as described in [CVE-2021-25740][].
Similar to the K8s EndpointSlice API, the Backend API can be misused to allow traffic to be sent to otherwise restricted destinations, as described in [CVE-2021-25740][].

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team June 10, 2024 18:17
@arkodg arkodg merged commit 3bd8f35 into envoyproxy:main Jun 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: backend
3 participants