Feat: adding support for PodDisruptionBudget with eg control plane #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwo
force-pushed
the
PodDisruptionBudget
branch
2 times, most recently
from
c18b34a to
86181a6
Compare
Signed-off-by: Alexander Volchok <[email protected]>
alexwo
force-pushed
the
PodDisruptionBudget
branch
from
86181a6 to
5698a61
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
=======================================
Coverage 68.17% 68.17%
=======================================
Files 168 168
Lines 20484 20484
=======================================
Hits 13964 13964
Misses 5511 5511
Partials 1009 1009 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexander Volchok <[email protected]>
|
/retest |
2 tasks
Signed-off-by: Alexander Volchok <[email protected]>
alexwo
force-pushed
the
PodDisruptionBudget
branch
from
f6ec14e to
cca1e46
Compare
guydc
reviewed
Jun 10, 2024
charts/gateway-addons-helm/README.md
Outdated
| @@ -0,0 +1,86 @@ | |||
| # gateway-addons-helm | |||
There was a problem hiding this comment.
Are the changes in gateway-addons-helm intentional?
| @@ -18,7 +18,8 @@ global: | |||
| pullPolicy: IfNotPresent | |||
| # List of secrets in the same namespace of the component that can be used to pull images from private repositories. | |||
| pullSecrets: [] | |||
|
|
|||
| podDisruptionBudget: | |||
There was a problem hiding this comment.
maybe keep this 0 for backwards compatibility?
There was a problem hiding this comment.
Changed this to 0.
This reverts commit cca1e46. Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
zirain
reviewed
Jun 11, 2024
test/helm/default-config.out.yaml
Outdated
| @@ -1,5 +1,19 @@ | |||
| --- | |||
| # Source: gateway-helm/templates/envoy-gateway-deployment.yaml | |||
| apiVersion: policy/v1 | |||
There was a problem hiding this comment.
this seems unreasonable, PDB should be opt-in.
There was a problem hiding this comment.
I have changed this, we will deploy an extra pdb resource only if podDisruptionBudget.minAvailable is configured to be > 0.
Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
|
/retest |
guydc
reviewed
Jun 11, 2024
| @@ -5,6 +5,20 @@ metadata: | |||
| namespace: '{{ .Release.Namespace }}' | |||
| labels: | |||
| {{- include "eg.labels" . | nindent 4 }} | |||
| --- | |||
| {{- if and .Values.podDisruptionBudget.minAvailable (ge (int .Values.podDisruptionBudget.minAvailable) 1) }} | |||
Signed-off-by: Alexander Volchok <[email protected]>
alexwo
force-pushed
the
PodDisruptionBudget
branch
from
6d65f31 to
019723b
Compare
|
/retest |
shawnh2
reviewed
Jun 12, 2024
test/helm/default-config.out.yaml
Outdated
| @@ -344,6 +344,7 @@ spec: | |||
| targetPort: 19001 | |||
| --- | |||
| # Source: gateway-helm/templates/envoy-gateway-deployment.yaml | |||
| --- | |||
There was a problem hiding this comment.
it would be nice if you can add some helm test, under test/helm
There was a problem hiding this comment.
Sure, I have added a test.
zirain
reviewed
Jun 12, 2024
|
can you rebase with |
Co-authored-by: zirain <[email protected]> Signed-off-by: Alex Volchok <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
alexwo
force-pushed
the
PodDisruptionBudget
branch
from
3847c3f to
e7318cc
Compare
Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a PDB, users can define policies that prevent too many instances of the Envoy Gateway control plane from being simultaneously disrupted during voluntary operations such as node upgrades, rolling updates, or manual interventions.
Adds EG controller pdp for #3546