helm: add more addons for gateway-addons-helm #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <[email protected]>
|
will update the observability doc, makefile and clean the helm-values under |
zirain
reviewed
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3541 +/- ##
==========================================
+ Coverage 68.17% 68.18% +0.01%
==========================================
Files 168 168
Lines 20484 20484
==========================================
+ Hits 13964 13967 +3
+ Misses 5511 5509 -2
+ Partials 1009 1008 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
zirain
previously approved these changes
Jun 11, 2024
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
arkodg
reviewed
Jun 11, 2024
arkodg
reviewed
Jun 11, 2024
arkodg
reviewed
Jun 11, 2024
| @@ -1,5 +1,12 @@ | |||
| tags: | |||
There was a problem hiding this comment.
to provide users more options to play with, also indicates which component is all about metrics or logging etc.
There was a problem hiding this comment.
ah TIL about this https://helm.sh/docs/topics/charts/#tags-and-condition-fields-in-dependencies :)
cnvergence
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref #3355