api: support user provided names for generated k8s resources #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arkodg
commented
Jun 3, 2024
arkodg
commented
- Users prefer setting their own custom names for generated k8s resources for the Envoy Proxy fleet instead of the autogenerated resource names
- https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717068088779319
- Add envoy gateway testing knative-extensions/net-gateway-api#738
- How is the envoy gateway kubernetes service name defined? #2141
* Users prefer setting their own custom names for generated k8s resources for the Envoy Proxy fleet instead of the autogenerated resources * https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717068088779319 * knative-extensions/net-gateway-api#738 * envoyproxy#2141 Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
+ Coverage 68.12% 68.17% +0.04%
==========================================
Files 165 165
Lines 20122 20122
==========================================
+ Hits 13708 13718 +10
+ Misses 5416 5409 -7
+ Partials 998 995 -3 ☔ View full report in Codecov by Sentry. |
shawnh2
approved these changes
Jun 4, 2024
zirain
approved these changes
Jun 4, 2024
cnvergence
approved these changes
Jun 4, 2024
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Jun 4, 2024
Relates to envoyproxy#3527 Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
added a commit
that referenced
this pull request
Jun 7, 2024
* feat: support custom names for generated k8s resources Relates to #3527 Signed-off-by: Arko Dasgupta <[email protected]> * use labels instead of name and ns to get deployment and svc Signed-off-by: Arko Dasgupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.