Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client backend mtls secrets updates #3526

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

alexwo
Copy link
Contributor

@alexwo alexwo commented Jun 3, 2024

What type of PR is this?
Ensure that if a secret is globally configured mtls secret is changed, envoy proxy refreshes repectivilty and uses the updated version when connecting to backends.

Fixes #3500

alexwo added 2 commits June 3, 2024 18:22
Signed-off-by: Alexander Volchok <[email protected]>
@alexwo alexwo changed the title fix Ensure that whenever client backend mTLS secrets are updated, the updated secrets are applied correctly. fix Ensure that whenever client backend mtls secrets are updated, the updated secrets are applied correctly. Jun 3, 2024
@alexwo alexwo changed the title fix Ensure that whenever client backend mtls secrets are updated, the updated secrets are applied correctly. fix client backend mtls secrets updates (mtls is configured via envoy proxy settings) Jun 3, 2024
@alexwo alexwo changed the title fix client backend mtls secrets updates (mtls is configured via envoy proxy settings) fix client backend mtls secrets updates Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (6e946db) to head (b07e105).

Files Patch % Lines
internal/provider/kubernetes/predicates.go 80.00% 3 Missing and 1 partial ⚠️
internal/provider/kubernetes/indexers.go 85.71% 1 Missing and 1 partial ⚠️
internal/provider/kubernetes/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3526      +/-   ##
==========================================
+ Coverage   68.13%   68.18%   +0.04%     
==========================================
  Files         165      165              
  Lines       20086    20120      +34     
==========================================
+ Hits        13686    13719      +33     
  Misses       5406     5406              
- Partials      994      995       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexwo alexwo marked this pull request as ready for review June 3, 2024 18:01
@alexwo alexwo requested a review from a team as a code owner June 3, 2024 18:01
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team June 3, 2024 18:26
@alexwo
Copy link
Contributor Author

alexwo commented Jun 3, 2024

/retest

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guydc guydc merged commit d2824e2 into envoyproxy:main Jun 3, 2024
23 checks passed
@alexwo alexwo deleted the mtls_secret_updates branch June 4, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: update envoyproxy (global) backend mTLS to use the latest secret details upon secret changes
3 participants