Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o11y: add grafana dashboard for control plane metrics #3506

Merged
merged 1 commit into from
May 30, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented May 30, 2024

What type of PR is this?

What this PR does / why we need it:

image image

Which issue(s) this PR fixes:

Fixes #3474

@shawnh2
Copy link
Contributor Author

shawnh2 commented May 30, 2024

can we ignore this doc-lint error https://github.com/envoyproxy/gateway/actions/runs/9304730041/job/25610019570?pr=3506#step:7:1279? because the dashboard and doc are updated at the same time.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this !

@arkodg arkodg requested review from a team May 30, 2024 20:39
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@arkodg arkodg merged commit 6021f9f into envoyproxy:main May 30, 2024
16 of 18 checks passed
@shawnh2 shawnh2 deleted the grafana-cp-metrics branch May 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs showing how to fetch Control Plane metrics
3 participants