chore: improve extension server unit tests #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC code and the regular extension manager instead of creating a testing-only variant. Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Lior Okman <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
+ Coverage 67.53% 67.82% +0.28%
==========================================
Files 168 166 -2
Lines 20154 20039 -115
==========================================
- Hits 13612 13592 -20
+ Misses 5558 5459 -99
- Partials 984 988 +4 ☔ View full report in Codecov by Sentry. |
|
/retest |
Signed-off-by: Lior Okman <[email protected]>
shawnh2
approved these changes
May 30, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running unit tests that touch the Extension Server, go through the gRPC code and the regular extension manager
instead of creating a testing-only variant.
This PR enables using an in-memory gRPC server implementation as the extension server, instead of bypassing the manager code during tests.
This improves coverage and removes testing code from the built binary.