feat: impl cluster buffer limit #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ShyunnY <[email protected]>
Signed-off-by: ShyunnY <[email protected]>
Signed-off-by: ShyunnY <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3479 +/- ##
==========================================
+ Coverage 67.22% 67.39% +0.17%
==========================================
Files 166 167 +1
Lines 19722 19955 +233
==========================================
+ Hits 13258 13449 +191
- Misses 5507 5540 +33
- Partials 957 966 +9 ☔ View full report in Codecov by Sentry. |
|
/retest |
shawnh2
reviewed
May 27, 2024
internal/gatewayapi/testdata/backendtrafficpolicy-buffer-limit-with-error.out.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: ShyunnY <[email protected]>
|
/retest |
1 similar comment
|
/retest |
arkodg
reviewed
May 28, 2024
internal/ir/xds.go
Outdated
| @@ -2024,6 +2030,13 @@ type TLSUpstreamConfig struct { | |||
| TLSConfig `json:",inline"` | |||
| } | |||
|
|
|||
| // BackendPolicyConnection settings for upstream connections | |||
| // +k8s:deepcopy-gen=true | |||
| type BackendPolicyConnection struct { | |||
Signed-off-by: ShyunnY <[email protected]>
Alice-Lilith
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type:
feat impl cluster buffer limit
What this PR does / why we need it:
description:
Support
per_connection_buffer_limit_bytesconfiguration on cluster by adding a knobWhich issue(s) this PR fixes:
Fixes #3278