Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:use server side apply when installing EG using kubectl #3451

Merged
merged 1 commit into from
May 22, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 21, 2024

Fixes: #3257

@arkodg arkodg requested a review from a team as a code owner May 21, 2024 22:53
@arkodg arkodg changed the title docs/install:use server side applywhen using kubectl docs:use server side apply when installing EG using kubectl May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.43%. Comparing base (db90b07) to head (9b0f34e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
+ Coverage   67.37%   67.43%   +0.06%     
==========================================
  Files         166      166              
  Lines       19357    19357              
==========================================
+ Hits        13041    13053      +12     
+ Misses       5376     5366      -10     
+ Partials      940      938       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested a review from a team May 21, 2024 23:42
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arkodg arkodg merged commit 101aa48 into envoyproxy:main May 22, 2024
26 checks passed
@arkodg arkodg deleted the server-side branch May 22, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails on vanilla cluster using the latest release
3 participants