Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: merge announcements and blogs into news #3417

Merged
merged 2 commits into from
May 17, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented May 17, 2024

What type of PR is this?

What this PR does / why we need it:

before:

image

after:

image

Which issue(s) this PR fixes:

Fixes #2987

@shawnh2 shawnh2 requested a review from a team as a code owner May 17, 2024 07:17
@shawnh2
Copy link
Contributor Author

shawnh2 commented May 17, 2024

HI, @wilsonwu can you also do the same refactor for the chinese doc? TIA

@wilsonwu
Copy link
Contributor

HI, @wilsonwu can you also do the same refactor for the chinese doc? TIA

No problem, I will sync ASAP after it is merged.

Signed-off-by: shawnh2 <[email protected]>
@shawnh2 shawnh2 force-pushed the doc/refactor-website branch from 5706651 to bf4284c Compare May 17, 2024 07:54
@@ -5,8 +5,6 @@ description: "本节讲述 Envoy Gateway 文档的开发工作。"

{{% alert title="注意" color="warning" %}}
我们已将 Envoy Gateway 文档从 **Sphinx** 迁移到 **Hugo**。

阅读博客:[Welcome to new website!](/blog/2023/10/08/welcome-to-new-website/)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove here just to pass doc-lint in ci, shall undo it when translating chinese doc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remember it and add it back with the sync to zh PR.

@wilsonwu
Copy link
Contributor

wilsonwu commented May 17, 2024

Not sure our site support alias link or not? For example if we change a blog link from /blog/2023/10/08/welcome-to-new-website/ to /news/blogs/new-website/new-website, we can add below info for the blog make the old link still work:

aliases:
  - /blog/2023/10/08/welcome-to-new-website/

@shawnh2
Copy link
Contributor Author

shawnh2 commented May 17, 2024

Not sure our site support alias link or not? For example if we change a blog link from /blog/2023/10/08/welcome-to-new-website/ to /news/blogs/new-website/new-website, we can add below info for the blog make the old link still work:

aliases:
  - /blog/2023/10/08/welcome-to-new-website/

Great input, let me try this!

@arkodg arkodg requested review from Xunzhuo and zirain May 17, 2024 16:18
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for improving the presentation !

@zirain zirain merged commit fe862e8 into envoyproxy:main May 17, 2024
23 of 24 checks passed
@shawnh2 shawnh2 deleted the doc/refactor-website branch May 17, 2024 18:35
wilsonwu added a commit to wilsonwu/gateway that referenced this pull request May 20, 2024
zirain pushed a commit that referenced this pull request May 21, 2024
* sync #3417 combine blog and release to news

Signed-off-by: Wilson Wu <[email protected]>

* clean old file

Signed-off-by: Wilson Wu <[email protected]>

* Fix bad link

Signed-off-by: Wilson Wu <[email protected]>

* remove notice migrate to hugo

Signed-off-by: Wilson Wu <[email protected]>

---------

Signed-off-by: Wilson Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: refactor the website
4 participants