Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(zh): translate Developer Guide and related docs into Chinese #3384

Merged
merged 8 commits into from
May 16, 2024
Merged

docs(zh): translate Developer Guide and related docs into Chinese #3384

merged 8 commits into from
May 16, 2024

Conversation

wilsonwu
Copy link
Contributor

What type of PR is this?
Translate Developer Guide and related docs into Chinese:

site/content/zh/contributions/DEVELOP.md
site/content/zh/latest/tasks/security/jwt-authentication.md
site/content/zh/latest/tasks/traffic/grpc-routing.md

@wilsonwu wilsonwu requested a review from a team as a code owner May 13, 2024 08:30
shawnh2
shawnh2 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good! Thanks.

site/content/zh/contributions/DEVELOP.md Outdated Show resolved Hide resolved
shawnh2
shawnh2 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, LGTM! Thanks!

site/content/zh/contributions/design/security-policy.md Outdated Show resolved Hide resolved
@shawnh2 shawnh2 requested review from zhaohuabing, zirain and Xunzhuo May 15, 2024 04:11
zhaohuabing
zhaohuabing approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain zirain merged commit c5ec046 into envoyproxy:main May 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@zirain zirain Awaiting requested review from zirain

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilsonwu @zhaohuabing @shawnh2 @zirain