Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golang to 1.22.3 #3351

Merged
merged 4 commits into from
May 9, 2024
Merged

chore: bump golang to 1.22.3 #3351

merged 4 commits into from
May 9, 2024

Conversation

shahar-h
Copy link
Contributor

@shahar-h shahar-h commented May 8, 2024

What this PR does / why we need it:
Bump golang version to 1.22.3 in order to resolve GO-2024-2824 .

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Shahar Harari <[email protected]>
@shahar-h shahar-h requested a review from a team as a code owner May 8, 2024 20:08
arkodg
arkodg previously approved these changes May 8, 2024
@shahar-h
Copy link
Contributor Author

shahar-h commented May 8, 2024

/retest

zirain
zirain previously approved these changes May 8, 2024
@shahar-h
Copy link
Contributor Author

shahar-h commented May 8, 2024

/retest

@zirain
Copy link
Member

zirain commented May 9, 2024

seems not a flaky?

Signed-off-by: Shahar Harari <[email protected]>
@shahar-h shahar-h dismissed stale reviews from arkodg and zirain via b2fc37b May 9, 2024 05:24
@shahar-h
Copy link
Contributor Author

shahar-h commented May 9, 2024

I changed go 1.22 to go 1.23 by accident in some e2e manifests, reverted: b2fc37b

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.12%. Comparing base (b90f81c) to head (b374fa5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
+ Coverage   67.11%   67.12%   +0.01%     
==========================================
  Files         164      164              
  Lines       23773    23773              
==========================================
+ Hits        15955    15958       +3     
+ Misses       6898     6896       -2     
+ Partials      920      919       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahar-h
Copy link
Contributor Author

shahar-h commented May 9, 2024

/retest

@zirain zirain merged commit 7124585 into envoyproxy:main May 9, 2024
25 checks passed
@shahar-h shahar-h deleted the go-1.22.3 branch May 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants