Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add trivy image vulnerabilities scan workflow #3287

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

shahar-h
Copy link
Contributor

@shahar-h shahar-h commented Apr 27, 2024

What this PR does / why we need it:
Introduced Trivy image vulnerabilities scan workflow:

  • This workflow will be triggered on merge to main and also once a week. I thought about triggering it also on PRs but I decided to avoid it in order to not block all PRs when a new vulnerability is detected.
  • I didn't upload scan results to GitHub code scanning since when choosing sarif output format results don't appear in stdout. Since code scanning results are not public I kept the default table format so anyone can see it. See related issue.
  • Currently only eg image is scanned. Regarding envoy-proxy and rate-limit images, I think that they should be scanned as part of their own repos CI process. We can discuss it later if needed.

Which issue(s) this PR fixes:

Fixes #3168

@shahar-h shahar-h requested a review from a team as a code owner April 27, 2024 09:16
Signed-off-by: Shahar Harari <[email protected]>
@shahar-h
Copy link
Contributor Author

/retest

3 similar comments
@shahar-h
Copy link
Contributor Author

/retest

@shahar-h
Copy link
Contributor Author

/retest

@shahar-h
Copy link
Contributor Author

/retest

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@zirain zirain merged commit f8ede24 into envoyproxy:main Apr 27, 2024
20 checks passed
@shahar-h shahar-h deleted the trivy-wf branch April 27, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Docker image vulnerabilities scan
3 participants