-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump github.com/envoyproxy/go-control-plane #3286
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
This version appears to be mirrored from envoy main (pending 1.31). If we release EG 1.1.0 according to the current timeline (https://github.com/envoyproxy/gateway/milestone/20), It's possible that envoy 1.31 would not be released yet. @envoyproxy/gateway-maintainers - should we pin envoy images and go-control-plane version to 1.30, or can we continue using latest artifacts here? |
Ok, so it’s probably better to cĺose it and open a new one when 1.31 is published |
Hi @mmorel-35 - TBH, I'm not sure what our policy should be here, we can keep this open and defer to other maintainers... |
There might be an official v1.12.1 or v1.13 to be used instead when it comes to merge it ;) |
Hi @mmorel-35 . We discussed this in the community meeting, and decided that since we use latest envoy images, we should also use latest go-control-plane in main. When we cut an RC, we'll pin both component versions and deal with any incompatible feature. So, you can resume this activity. |
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
/retest |
What type of PR is this?
What this PR does / why we need it:
bump github.com/envoyproxy/go-control-plane
Replace github.com/golang/protobuf/ptypes with google.golang.org/protobuf/types
Which issue(s) this PR fixes:
Fixes #