Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/envoyproxy/go-control-plane #3286

Merged
merged 3 commits into from
May 2, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 26, 2024

What type of PR is this?

What this PR does / why we need it:

bump github.com/envoyproxy/go-control-plane
Replace github.com/golang/protobuf/ptypes with google.golang.org/protobuf/types

Which issue(s) this PR fixes:

Fixes #

@mmorel-35 mmorel-35 marked this pull request as ready for review April 26, 2024 21:48
@mmorel-35 mmorel-35 requested a review from a team as a code owner April 26, 2024 21:48
@guydc
Copy link
Contributor

guydc commented Apr 26, 2024

This version appears to be mirrored from envoy main (pending 1.31). If we release EG 1.1.0 according to the current timeline (https://github.com/envoyproxy/gateway/milestone/20), It's possible that envoy 1.31 would not be released yet.

@envoyproxy/gateway-maintainers - should we pin envoy images and go-control-plane version to 1.30, or can we continue using latest artifacts here?

@mmorel-35 mmorel-35 marked this pull request as draft April 27, 2024 07:30
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Apr 27, 2024

Ok, so it’s probably better to cĺose it and open a new one when 1.31 is published

@mmorel-35 mmorel-35 closed this Apr 27, 2024
@guydc
Copy link
Contributor

guydc commented Apr 27, 2024

Hi @mmorel-35 - TBH, I'm not sure what our policy should be here, we can keep this open and defer to other maintainers...

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Apr 27, 2024

There might be an official v1.12.1 or v1.13 to be used instead when it comes to merge it ;)

@guydc
Copy link
Contributor

guydc commented May 2, 2024

Hi @mmorel-35 . We discussed this in the community meeting, and decided that since we use latest envoy images, we should also use latest go-control-plane in main. When we cut an RC, we'll pin both component versions and deal with any incompatible feature. So, you can resume this activity.

@mmorel-35 mmorel-35 reopened this May 2, 2024
mmorel-35 added 2 commits May 2, 2024 21:36
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 marked this pull request as ready for review May 2, 2024 19:57
@guydc
Copy link
Contributor

guydc commented May 2, 2024

/retest

@arkodg arkodg merged commit 59fdb84 into envoyproxy:main May 2, 2024
20 checks passed
@mmorel-35 mmorel-35 deleted the protobuf branch May 3, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants