-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump k8s.io #3281
chore: Bump k8s.io #3281
Conversation
Bumps the k8s-io group with 6 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.29.3` | `0.30.0` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.29.3` | `0.30.0` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.29.3` | `0.30.0` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.29.3` | `0.30.0` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.29.3` | `0.30.0` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.29.3` | `0.30.0` | Updates `k8s.io/api` from 0.29.3 to 0.30.0 - [Commits](kubernetes/api@v0.29.3...v0.30.0) Updates `k8s.io/apiextensions-apiserver` from 0.29.3 to 0.30.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.29.3...v0.30.0) Updates `k8s.io/apimachinery` from 0.29.3 to 0.30.0 - [Commits](kubernetes/apimachinery@v0.29.3...v0.30.0) Updates `k8s.io/cli-runtime` from 0.29.3 to 0.30.0 - [Commits](kubernetes/cli-runtime@v0.29.3...v0.30.0) Updates `k8s.io/client-go` from 0.29.3 to 0.30.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.29.3...v0.30.0) Updates `k8s.io/kubectl` from 0.29.3 to 0.30.0 - [Commits](kubernetes/kubectl@v0.29.3...v0.30.0) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
return err | ||
} | ||
|
||
// Only enqueue EnvoyProxy objects that match this Envoy Gateway's GatewayClass. | ||
epPredicates := []predicate.Predicate{ | ||
predicate.GenerationChangedPredicate{}, | ||
predicate.ResourceVersionChangedPredicate{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arkodg is this a must?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you track the orig commit for ResourceVersionChangedPredicate
? did the type get removed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can find a typed Predicate about that, actually I didn't understand why EG need it only for this.
fix: #3237