Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix global rate limit doc for sourceCIDR type #3256

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

owenhaynes
Copy link
Contributor

What this PR does / why we need it:
Fix's the doc to use the correct enum names for the sourceCIDR type for global rate limiting. This could be a bug in the translator but this fixes the doc in case it not.

@owenhaynes owenhaynes requested a review from a team as a code owner April 23, 2024 18:07
zhaohuabing
zhaohuabing previously approved these changes Apr 23, 2024
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@arkodg
Copy link
Contributor

arkodg commented Apr 23, 2024

can you also update site/content/en/v1.0.1/tasks/traffic/global-rate-limit.md with the same diff, tia !

@owenhaynes
Copy link
Contributor Author

@arkodg this has been done.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zhaohuabing zhaohuabing merged commit c43efbc into envoyproxy:main Apr 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants