Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crds: remove status #3229

Merged
merged 4 commits into from
Apr 22, 2024
Merged

crds: remove status #3229

merged 4 commits into from
Apr 22, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Apr 21, 2024

since EG move to use gwapiv1a2.PolicyStatus, this won't work any more.

Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from a team as a code owner April 21, 2024 08:15
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Users can also scrape the policy status via egctl x status xpolicy now.

@zirain
Copy link
Member Author

zirain commented Apr 21, 2024

/retest

@guydc
Copy link
Contributor

guydc commented Apr 22, 2024

/retest

@guydc guydc merged commit f6b35ba into envoyproxy:main Apr 22, 2024
17 checks passed
@zirain zirain deleted the remove-status branch April 23, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants