Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP2 settings API #3222

Merged
merged 12 commits into from
Apr 22, 2024
Merged

HTTP2 settings API #3222

merged 12 commits into from
Apr 22, 2024

Conversation

zhaohuabing
Copy link
Member

Related: #3048

@zhaohuabing
HTTP2 settings API
623645b 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner April 19, 2024 17:01
@zhaohuabing zhaohuabing requested review from arkodg and guydc April 19, 2024 17:09
@zhaohuabing
api for http2 settings
0307de7 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
fix typo
08f70fe 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
fix test
bc6604b 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
fix
76770e7 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
fix
c9de60e 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
fix
352260d 
Signed-off-by: huabing zhao <[email protected]>
guydc
guydc reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@guydc guydc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would like to see two more knobs supported.

internal/gatewayapi/clienttrafficpolicy.go Outdated Show resolved Hide resolved
api/v1alpha1/clienttrafficpolicy_types.go Outdated Show resolved Hide resolved
@zhaohuabing
fix test
a83a16e 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
Merge branch 'main' into http2-listener-setting
af7cd8e
@zhaohuabing
fix test
8d8b76b 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
fix test
65df813 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
add validation test
ed82138 
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing zhaohuabing requested review from arkodg and guydc April 22, 2024 18:04
guydc
guydc approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

arkodg
arkodg approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 378a1f0 into envoyproxy:main Apr 22, 2024
20 checks passed
@zhaohuabing zhaohuabing mentioned this pull request Apr 22, 2024
Merged
@guydc guydc mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guydc guydc guydc approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaohuabing @arkodg @guydc