feat: add support for optional JWT authentication #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
reviewed
Apr 12, 2024
ardikabs
force-pushed
the
feat/optional-jwt-auth
branch
3 times, most recently
from
caedc38 to
122129d
Compare
|
/retest |
arkodg
reviewed
Apr 17, 2024
api/v1alpha1/jwt_types.go
Outdated
| @@ -8,6 +8,10 @@ package v1alpha1 | |||
| // JWT defines the configuration for JSON Web Token (JWT) authentication. | |||
| type JWT struct { | |||
|
|
|||
| // AllowMissing determines whether a missing JWT is acceptable, defaulting to false if not specified. | |||
| // Note: Even if allowMissing is set to true, JWT authentication will still fail if an invalid JWT is presented. | |||
| AllowMissing *bool `json:"allowMissing,omitempty"` | |||
There was a problem hiding this comment.
hey @ardikabs, we discussed this in the community meeting last week, and most preferred Optional over AllowMissing , can we update this ?
There was a problem hiding this comment.
@arkodg
can we keep the naming convention AllowMissing in the IR while using Optional in the user interface (CRD)?
Signed-off-by: Ardika Bagus <[email protected]>
Signed-off-by: Ardika Bagus <[email protected]>
Signed-off-by: Ardika Bagus <[email protected]>
ardikabs
force-pushed
the
feat/optional-jwt-auth
branch
from
122129d to
b90ad69
Compare
|
/retest |
Signed-off-by: Ardika Bagus <[email protected]>
ardikabs
force-pushed
the
feat/optional-jwt-auth
branch
from
b90ad69 to
f744ddd
Compare
zirain
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3081