correct kubectl command to show deployment in envoy-gateway-system na… #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
==========================================
+ Coverage 66.48% 66.50% +0.02%
==========================================
Files 161 161
Lines 22632 22632
==========================================
+ Hits 15046 15051 +5
+ Misses 6714 6710 -4
+ Partials 872 871 -1 ☔ View full report in Codecov by Sentry. |
|
thanks @eitansuez ! can you also make the same change for the |
zirain
previously approved these changes
Apr 4, 2024
|
ah, thanks, i overlooked that. ok, change applied also to latest. |
added 2 commits
April 4, 2024 09:02
…mespace Signed-off-by: Eitan Suez <[email protected]>
…mespace - v latest Signed-off-by: Eitan Suez <[email protected]>
eitansuez
force-pushed
the
customize-proxy-replicas
branch
from
c640d04 to
09448f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
i believe it was an omission - the deployment in question resides in envoy-gateway-system