-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: ext-proc timeout, fail-open, backendRefs #3087
Conversation
Signed-off-by: Guy Daich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3087 +/- ##
==========================================
- Coverage 66.51% 66.47% -0.04%
==========================================
Files 161 160 -1
Lines 22673 22553 -120
==========================================
- Hits 15080 14992 -88
+ Misses 6720 6693 -27
+ Partials 873 868 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Guy Daich <[email protected]>
/retest |
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
/retest |
@@ -11,6 +11,8 @@ package celvalidation | |||
import ( | |||
"context" | |||
"fmt" | |||
"k8s.io/utils/ptr" | |||
gwapiv1 "sigs.k8s.io/gateway-api/apis/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort the imports please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
/retest |
Signed-off-by: Guy Daich <[email protected]>
@@ -14,8 +14,26 @@ import ( | |||
// | |||
// ExtProc defines the configuration for External Processing filter. | |||
type ExtProc struct { | |||
// Service defines the configuration of the external processing service | |||
// BackendRef defines the configuration of the external processing service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plan on deleting backendRef
in a follow up PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm this is a API PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
Support timeout, fail open mode and plural backend refs for external processor.
The implementation PR will:
Which issue(s) this PR fixes:
xref: #3170