Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: ext-proc timeout, fail-open, backendRefs #3087

Merged
merged 14 commits into from
Apr 16, 2024
Merged

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Apr 3, 2024

What this PR does / why we need it:
Support timeout, fail open mode and plural backend refs for external processor.
The implementation PR will:

  • Remove singular BackendRef (no compatibility issue with released API versions).
  • Make backendRefs mandatory.

Which issue(s) this PR fixes:
xref: #3170

Signed-off-by: Guy Daich <[email protected]>
@guydc guydc requested a review from a team as a code owner April 3, 2024 20:00
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.47%. Comparing base (29946b0) to head (d1660ee).
Report is 38 commits behind head on main.

❗ Current head d1660ee differs from pull request most recent head da182e8. Consider uploading reports for the commit da182e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   66.51%   66.47%   -0.04%     
==========================================
  Files         161      160       -1     
  Lines       22673    22553     -120     
==========================================
- Hits        15080    14992      -88     
+ Misses       6720     6693      -27     
+ Partials      873      868       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guydc
Copy link
Contributor Author

guydc commented Apr 9, 2024

/retest

@guydc guydc added this to the v1.1.0-rc1 milestone Apr 10, 2024
@guydc guydc changed the title api: extend ext-proc api: ext-proc timeout, fail-open Apr 10, 2024
@guydc guydc added the area/api API-related issues label Apr 10, 2024
guydc added 2 commits April 10, 2024 12:22
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
@guydc
Copy link
Contributor Author

guydc commented Apr 10, 2024

/retest

@@ -11,6 +11,8 @@ package celvalidation
import (
"context"
"fmt"
"k8s.io/utils/ptr"
gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort the imports please

arkodg
arkodg previously approved these changes Apr 12, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkodg arkodg requested review from shawnh2 and a team April 12, 2024 05:58
@guydc guydc changed the title api: ext-proc timeout, fail-open api: ext-proc timeout, fail-open, backendRefs Apr 12, 2024
Signed-off-by: Guy Daich <[email protected]>
@guydc
Copy link
Contributor Author

guydc commented Apr 12, 2024

/retest

Signed-off-by: Guy Daich <[email protected]>
@guydc guydc requested a review from arkodg April 15, 2024 12:31
@@ -14,8 +14,26 @@ import (
//
// ExtProc defines the configuration for External Processing filter.
type ExtProc struct {
// Service defines the configuration of the external processing service
// BackendRef defines the configuration of the external processing service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plan on deleting backendRef in a follow up PR ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm this is a API PR

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arkodg arkodg merged commit ad54e06 into envoyproxy:main Apr 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants