Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ignore path for codecov #3072

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Apr 1, 2024

What type of PR is this?

What this PR does / why we need it:

Add ignore-paths to codecov config to ignore certain paths, give the coverage a boost by ignoring unrelevant code.

@shawnh2 shawnh2 requested a review from a team as a code owner April 1, 2024 04:00
@shawnh2
Copy link
Contributor Author

shawnh2 commented Apr 1, 2024

/retest

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (7bed6fa) to head (a329b4d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
+ Coverage   58.88%   67.70%   +8.82%     
==========================================
  Files         162      154       -8     
  Lines       27083    21551    -5532     
==========================================
- Hits        15948    14592    -1356     
+ Misses      10182     6117    -4065     
+ Partials      953      842     -111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: shawnh2 <[email protected]>
@zirain
Copy link
Contributor

zirain commented Apr 1, 2024

/retest

@zirain zirain merged commit 9416798 into envoyproxy:main Apr 2, 2024
19 checks passed
@shawnh2 shawnh2 deleted the ignore-codecov branch April 2, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants