Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Model OpenTelelemetry Sinks as a BackendRef #3067

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Mar 31, 2024

xref: #3041

@zirain zirain requested a review from a team as a code owner March 31, 2024 03:28
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 58.05%. Comparing base (69ffac8) to head (f1c34f7).
Report is 1 commits behind head on main.

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 0.00% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   58.05%   58.05%   -0.01%     
==========================================
  Files         165      165              
  Lines       27458    27475      +17     
==========================================
+ Hits        15942    15950       +8     
- Misses      10561    10571      +10     
+ Partials      955      954       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain force-pushed the opentelemetry-backendref branch from 264efa7 to b8cc75f Compare March 31, 2024 04:01
@zirain
Copy link
Contributor Author

zirain commented Mar 31, 2024

wait #3068 merged to make this PR cleaner

@zirain zirain force-pushed the opentelemetry-backendref branch from cf8af83 to 02e845b Compare April 1, 2024 03:15
@zirain zirain force-pushed the opentelemetry-backendref branch from 02e845b to 594e5a9 Compare April 1, 2024 03:19
tools/make/golang.mk Outdated Show resolved Hide resolved
@zirain zirain requested a review from arkodg April 1, 2024 12:28
Signed-off-by: zirain <[email protected]>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@zhaohuabing zhaohuabing merged commit 06e4f39 into envoyproxy:main Apr 2, 2024
21 of 22 checks passed
@zirain zirain deleted the opentelemetry-backendref branch April 2, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants