-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Model OpenTelelemetry Sinks as a BackendRef #3067
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 58.05% 58.05% -0.01%
==========================================
Files 165 165
Lines 27458 27475 +17
==========================================
+ Hits 15942 15950 +8
- Misses 10561 10571 +10
+ Partials 955 954 -1 ☔ View full report in Codecov by Sentry. |
264efa7
to
b8cc75f
Compare
wait #3068 merged to make this PR cleaner |
cf8af83
to
02e845b
Compare
Signed-off-by: zirain <[email protected]>
02e845b
to
594e5a9
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
xref: #3041